This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] libdw: initialize state early in read_srclines

From: Mark Wielaard <mjw at redhat dot com>
To: elfutils-devel at lists dot fedorahosted dot org
Date: Mon, 16 Nov 2015 17:13:36 +0100
Subject: Re: [PATCH] libdw: initialize state early in read_srclines

On Mon, 2015-11-16 at 18:11 +0300, Dmitry V. Levin wrote:
> Starting with commit f8443bd09f8a8d3d84a63e5ce206a218e57dff7a,
> we might jump to "out" on error before initialization of "state".
> Initialize "state" early to fix this issue.

Right, and "out" cleans up using some of the "state" following the
linelist pointer. So we better make sure that is always setup correctly.

Added a ChangeLog entry and applied to master.

Thanks,

Mark

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]