This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch rfc: debuginfod -Z (generalized archive) support


Hi Frank,

On Fri, Feb 07, 2020 at 06:44:02AM -0500, Frank Ch. Eigler wrote:
> > [...] I think it would be better if you could simply leave off the
> > conversion CMD and just provide an EXT (without =). This would then
> > just pass the file with the given extension to libarchive directly
> > (then you also don't need the zstdcat conversion). And letting
> > libarchive handle it directly might be more efficient.
> 
> How about making =CMD optional.  If it's missing, debuginfod would
> assume "cat".  (I'd prefer not to have to change the code again for
> some other distro that has a thin wrapper around a libarchive-readable
> format, where something like rpm2cpio or dog would be needed.)

Yes, lets make =CMD optional. But why assume "cat"? Can't you then
simply use fopen instaed of popen in the code to get the FILE* to pass
to archive_read_open_FILE? Or even just open and archive_read_open_fd?

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]