This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [[RESEND & PING]PATCH V3 0/1] Add C-SKY support
- From: Mark Wielaard <mark at klomp dot org>
- To: Mao Han <han_mao at c-sky dot com>, elfutils-devel at sourceware dot org
- Date: Fri, 12 Jul 2019 23:49:07 +0200
- Subject: Re: [[RESEND & PING]PATCH V3 0/1] Add C-SKY support
- References: <cover.1559544994.git.han_mao@c-sky.com>
On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote:
> 5. run-reverse-sections-self.sh
> elfcopy --reverse-offs dose not work properly on C-SKY object file,
> seems not related to arch specific code.
> size.o before copy:
> https://github.com/c-sky/test-result/blob/master/elfutils/size.o
> size.o.rev after copy:
> https://github.com/c-sky/test-result/blob/master/elfutils/size.o.rev
This might be because these files are also EM_RCE instead of EM_CSKY.
But most likely it was because there was a bug in the testcase.
Make sure you have commit d08c68 tests: elfcopy --reverse-offs should
only swap sections next to each other.
It looks like in the original the .csky.attributes and .shstrtab are
not really next to each other (they have consecutive section numbers,
but the file offsets are far apart). And that could have fooled the
original test case.
Please make sure you have the above commit/fix in your tree and see if
it passes then.
Thanks,
Mark