This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.
- From: Lei Zhang <thestig at chromium dot org>
- To: Mark Wielaard <mark at klomp dot org>
- Cc: elfutils-devel at sourceware dot org, fche at redhat dot com, mcermak at redhat dot com, Dirk Pranke <dpranke at chromium dot org>, Thomas Anderson <thomasanderson at chromium dot org>
- Date: Wed, 3 Jul 2019 08:23:11 -0700
- Subject: Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.
- References: <1560902643-20602-1-git-send-email-mark@klomp.org> <CACSHbcTrj5-K9hwZcGf19s_+m8=9VOr1ta+gVR512T3+wRivTA@mail.gmail.com> <b135aef199d4cf03894762b1df72ed1fde0bc42a.camel@klomp.org> <CACSHbcQd6JMh2COkMH=-fg9s2yUi5OCneFgT98L5P=YwMHkLsg@mail.gmail.com> <16d89e8e2447abcb8fa5d626ff88534f1d28a08a.camel@klomp.org>
On Wed, Jul 3, 2019 at 7:53 AM Mark Wielaard <mark@klomp.org> wrote:
> Thanks for the file, it is indeed pretty big :)
> But I am not able to replicate the issue with elfutils from git trunk.
> commit 31c8b3f098b0654db8f573b2a15d5b6d07d4d3b0
>
> And both the produced chrome_elfutil_test.stripped and
> chrome_elfutil_test.debug files seem valid ELF files.
I figured out the problem on my side. The strip binary dynamically
linked to /usr/lib/x86_64-linux-gnu/libelf.so.1 and friends. Once I
set LD_LIBRARY_PATH, I got the expected output.
> But you might not be using the upstream build system, and you might use
> different flags to call it. So, two questions. How did you build your
> eu-strip binary? And how do you invoke it?
I'm building at the same commit on 64-bit Linux:
git clone git://sourceware.org/git/elfutils.git
cd elfutils
autoreconf -i -f
./configure --enable-maintainer-mode
make
make check
cp ./src/strip /path/to/chrome/src/buildtools/third_party/eu-strip/bin/eu-strip
Then I did the build on the Chromium side, which essentially runs:
strip -o chrome.stripped -f chrome.debug chrome