This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] configure: Add new --enable-install-elfh option.


> Yes, it should indeed.
> I used a slightly different solution though.
> It relies on the default include flags already including the srcdirs.
> Does that work for your use case too? (See revised patch attached.)

I'm not an expert in autotools. The reason I also have "else" case in my 
code is that I want to do "+=" in the USE_GNULIB case below. That only 
works if system_elf_libelf_test_CPPFLAGS is defined, which curiously it 
is not if you don't explicitly set it before (even though it is 
implicitly there somehow ... ?!?).

In particular I get the following error from autoconf if I naively merge 
your patch:

> Ulf@Ulf-PC MINGW64 /d/elfutils$ autoreconf -fi
> tests/Makefile.am:617: error: cannot apply '+=' because 'system_elf_libelf_test_CPPFLAGS' is not defined in
> tests/Makefile.am:617: the following conditions:
> tests/Makefile.am:617:   INSTALL_ELFH and USE_GNULIB
> tests/Makefile.am:617: either define 'system_elf_libelf_test_CPPFLAGS' in these conditions, or use
> tests/Makefile.am:617: '+=' in the same conditions as the definitions.
> autoreconf: automake failed with exit status: 1

As this only applies to my code, you are of course free to apply your 
version upstream. It probably makes no difference if the USE_GNULIB case 
isn't there. I will adapt my code then.

best,
Ulf

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]