This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Use separate files for strip outputs
- From: Mark Wielaard <mark at klomp dot org>
- To: Ulf Hermann <ulf dot hermann at qt dot io>
- Cc: "elfutils-devel at sourceware dot org" <elfutils-devel at sourceware dot org>
- Date: Wed, 23 Jan 2019 23:19:53 +0100
- Subject: Re: [PATCH] Use separate files for strip outputs
- References: <39ab92cc-9cd9-69ed-b053-c979f242949a@qt.io>
On Fri, Jan 18, 2019 at 12:56:28PM +0000, Ulf Hermann wrote:
> Let's see if this works: Apparently I cannot get a properly formatted
> inline diff through. Therefore, please find the pull request, including
> diff, as attachment.
That certainly works.
git pull https://codereview.qt-project.org/qt-creator/elfutils changes/37/250337/3
git rebase master
Applies cleanly.
The only thing I would change is removing the Change-ID line.
As you say in your commit message this exposes that the
run-strip-test-many.sh actually fails. Indeed, even without
you patch you can see src/strip: illformed file 'testfile'
in the run-strip-test-many.sh.log (but without actually failing
the test...
I am still investgating why/how it is failing.
Will apply your patch afterwards.
Thanks,
Mark