Re: [PATCH] RISC-V: Add untested 32-bit core file support.

[Mark Wielaard <mark at klomp dot org>]

On Thu, 2018-12-27 at 15:27 -0800, Jim Wilson wrote:
> This conflicts with the previoues two patches.  Adds 32-bit support exactly the
> same way that the sparc backend handles 32- and 64-bit core file support.  The
> 64-bit core file support was tested and still works same as before.

I don't really like adding code that cannot be tested. But it does look
the 32-bit port isn't far off, just waiting for the next linux/glibc
release to settle the time_t ABI. And the code does look correct.
Except for...

> static const Ebl_Register_Location prstatus_regs[] =
>    {
> -    { .offset = 8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */
> +    { .offset = BITS/8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */
>    };

Should that be .bits = BITS ?

Thanks,

Mark