This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Remove previous test files before running the next round

From: Mark Wielaard <mark at klomp dot org>
To: Ulf Hermann <ulf dot hermann at qt dot io>
Cc: elfutils-devel at sourceware dot org
Date: Tue, 17 Jul 2018 12:33:48 +0200
Subject: Re: [PATCH 1/2] Remove previous test files before running the next round
References: <87ac4132-25a7-cb0a-e3f0-a6c5495f0426@qt.io> <20180716215755.GA8971@wildebeest.org>

On Mon, 2018-07-16 at 23:57 +0200, Mark Wielaard wrote:
> On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote:
> > strip explicitly creates the new files. This will not work on
> > windows if
> > the files already exist.
> > 
> > Also, if strip fails to create the files for any reason, we would
> > check
> > the previous run's files and succeed. However, the test should fail
> > then.
> 
> This makes sense and does uncover a bug as your second patch shows.
> I want to fix that first and only then commit this fix. That way we
> don't have the testsuite failing between commits.

Pushed now that we have an updated hello_riscv64.ko test file.

Thanks,

Mark

References:
- [PATCH 1/2] Remove previous test files before running the next round
  - From: Ulf Hermann
- Re: [PATCH 1/2] Remove previous test files before running the next round
  - From: Mark Wielaard

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]