This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] tests: Add varlocs-self and exprlocs-self tests.
On Wed, 2017-11-15 at 21:01 +0100, Mark Wielaard wrote:
> On Fri, 2017-11-10 at 17:12 +0100, Mark Wielaard wrote:
> > Make sure the testcases (library functions they use) don't crash,
> > triggers self-check/asserts or leaks memory under valgrind. This
> > also helps making sure newer DWARF constructs are handled (when
> > building with -gdwarf-5).
> I pushed this to master now.
I setup a buildbot that checks all commits on various setups.
It found an issue with this patch on ppc64/ppc64le:
It was caused by a silly typo...
I pushed the attached to master as obvious.
From 1af6c2b9e49f59ea2f01035738525e798bb4f645 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <firstname.lastname@example.org>
Date: Thu, 16 Nov 2017 13:20:11 +0100
Subject: [PATCH] tests: Fix cfi_debug => cfi_debug_bias typo in varlocs
We want to check whether the bias is zero, not whether we have dwarf
This triggered on a ppc64/ppc64le self-check since it has both
debug_frame and eh_frame cfi (other arches often only have eh_frame).
Signed-off-by: Mark Wielaard <email@example.com>
tests/ChangeLog | 4 ++++
tests/varlocs.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 6c8a8e1..0162034 100644
@@ -1,3 +1,7 @@
+2017-11-16 Mark Wielaard <firstname.lastname@example.org>
+ * varlocs.c (main): Fix cfi_debug => cfi_debug_bias typo in assert.
2017-11-10 Mark Wielaard <email@example.com>
* run-exprlocs-self.sh: New test.
diff --git a/tests/varlocs.c b/tests/varlocs.c
index 3267198..0e43229 100644
@@ -1031,7 +1031,7 @@ main (int argc, char *argv)
cfi_debug = dwfl_module_dwarf_cfi (mod, &cfi_debug_bias);
cfi_eh = dwfl_module_eh_cfi (mod, &cfi_eh_bias);
- assert (cfi_debug == 0); // No bias needed, same file.
+ assert (cfi_debug_bias == 0); // No bias needed, same file.
// We are a bit forgiving for object files. There might be
// relocations we don't handle that are needed in some