This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] lib: sha1, md5, use memmove to move bytes inside buffer, not memcpy.


On Mon, 2017-10-16 at 13:00 +0200, Mark Wielaard wrote:
> At the end of {sha1,md5}_process_bytes we move the contents of
> ctx->buffer up to the start of the buffer. Since this means the
> source and destination overlap we should use memmove, not memcpy.

I am retracting this patch since I noticed nothing was actually using
this code except for one testcase. I'll post a patch removing the
implementation and the testcase.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]