This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH v2] Check if gcc complains about __attribute__ (visibility(..))
- From: Mark Wielaard <mark at klomp dot org>
- To: Ulf Hermann <ulf dot hermann at qt dot io>
- Cc: elfutils-devel at sourceware dot org
- Date: Fri, 18 Aug 2017 22:38:37 +0200
- Subject: Re: [PATCH v2] Check if gcc complains about __attribute__ (visibility(..))
- Authentication-results: sourceware.org; auth=none
- References: <email@example.com>
On Fri, Aug 18, 2017 at 01:06:36PM +0200, Ulf Hermann wrote:
> If so, define attribute_hidden to be empty. Also, use attribute_hidden
> in all places where we hide symbols. If this attribute is missing, it
> simply means that we cannot hide private symbols in the binary using
> attributes. This disables some optimizations and may increase the risk
> of symbol name clashes with other libraries, but is not fatal.
> However, we still employ linker version scripts to explicitly define
> the exported symbols. This serves much of the same purpose. Also, as
> all our symbols are prefixed with the library name, and "__" for
> private ones, the chance of clashes is low anyway.
Like the previous one, I have my doubts. But it actually makes the
source code slightly more consistent. So applied.