This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] ppc64: Add minimal fallback unwinder.
- From: Paolo Bonzini <pbonzini at redhat dot com>
- To: Mark Wielaard <mark at klomp dot org>, "Naveen N. Rao" <naveen dot n dot rao at linux dot vnet dot ibm dot com>
- Cc: elfutils-devel at sourceware dot org, Ravi Bangoria <ravi dot bangoria at linux dot vnet dot ibm dot com>
- Date: Tue, 30 May 2017 17:52:58 +0200
- Subject: Re: [PATCH] ppc64: Add minimal fallback unwinder.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 4B3698124A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4B3698124A
- References: <firstname.lastname@example.org> <20170530075850.GL19390@naverao1-tp.localdomain> <email@example.com>
On 30/05/2017 16:37, Mark Wielaard wrote:
> On Tue, 2017-05-30 at 13:28 +0530, Naveen N. Rao wrote:
>>> + if (! readfunc(sp + LR_OFFSET, &newLr, arg))
>> should this be newSp + LR_OFFSET, since the LR save area is in the
>> caller's stack frame?
> Of course. You are entirely right.
> This also explains why the testcase didn't seem to work correctly.
> It actually does with this change. I should have been more suspicious
> about that then just assuming it was because the link register couldn't
> always be retrieved correctly. It actually can if we pick it from the
> right location!
> Attached the fixed patch plus a testcase (actual binaries removed from
> patch, but testcase documents how they were generated - precisely like
> for the other arches).
Great, I'll resubmit my kernel patch then!