Re: [PATCH] debug/gdb: add extra config for gdb cross

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Michael, Zhenqiang, All,

On Wednesday 23 November 2011 22:07:37 Michael Hope wrote:
> On Thu, Nov 24, 2011 at 12:40 AM, Zhenqiang Chen
> <zhenqiang.chen@linaro.org> wrote:
> > # HG changeset patch
> > # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> > # Date 1322025327 -28800
> > # Node ID e3a6a636cfa9013ddd0855ca9eb8d3a35dad3249
> > # Parent  2f4e3c312b659422e4a9950f13a0fc507b97c1fd
> > debug/gdb: add extra config for gdb cross.
> >
> > Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
> >
> > diff --git a/config/debug/gdb.in.cross b/config/debug/gdb.in.cross
> > --- a/config/debug/gdb.in.cross
> > +++ b/config/debug/gdb.in.cross
> > @@ -39,4 +39,11 @@
> >       have been reports of problems when linking gdb to the static
> >       libpython.a. This should be fixed in gdb >=7.3. YMMV.
> >
> > +config GDB_CROSS_EXTRA_CONFIG_ARRAY
> > +    string
> > +    prompt "Extra config for gdb cross"
> 
> Should this be "Cross-gdb extra config" to be consistent with the
> other arrays in binutils, glibc, and gcc?

Yes, I'll change here before committing.

> > +    default ""
> > +    help
> > +      Extra flags to pass onto ./configure when configuring the gdb cross.
> > +
> >  endif # GDB_CROSS
> > diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
> > --- a/scripts/build/debug/300-gdb.sh
> > +++ b/scripts/build/debug/300-gdb.sh
> > @@ -147,7 +147,8 @@
> >             --with-sysroot="${CT_SYSROOT_DIR}"          \
> >             --with-expat=yes                            \
> >             --disable-werror                            \
> > -            "${cross_extra_config[@]}"
> > +            "${cross_extra_config[@]}"                  \
> 
> Huh.  The trailing \ looks fine in Thunderbird but is one character
> short in gmail's view original.

I looked at the raw message, and somehow a leading space is added to every
lines that already start with a space.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq