Re: Patch for building Java compiler for version 4.3.0+

["Yann E. MORIN" <yann dot morin dot 1998 at anciens dot enib dot fr>]

Andy,
All,

On Tuesday 06 January 2009 22:17:12 Andy Johnson wrote:
> I noticed in gcc.sh at least for single line if statements that
> the syntax was "[ test ] && statement" whereas "if [ test ]; then
> statement1; statement; fi" is used for multi-line blocks.  In this
> patch you used the second form for a single line statement.  Is
> this the preferred form going forward?

If the line is "quite long", I'd use if-then-else, if the line is "quite
short", I'd use [...] &&. Here, "Quite long" and "quite short" being
really dependent on the curent phase of the moon.

In this case, I'd use if-then-else because the line is "quite long".

> > > I don't know how to do a list of possible ftp sites to get the
> > > ecj-latest.jar file, but another is at
> > ftp://sourceware.org/pub/java/.
> I wasn't sure what the syntax would be.  I have added it to my patch.

Correct.

> I'm using SVN version 1294 and it seems to be working so far.

OK. No need to resend, I'll adapt and apply.

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| --==< ^_^ >==-- `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'


--
For unsubscribe information see http://sourceware.org/lists.html#faq