Re: [Fwd: [patch][rfa]: Decoding insns > 32 bits in length] - Opinion requested from Nick Clifton

[Nick Clifton <nickc at cambridge dot redhat dot com>]

Hi Dave,

> I was asked to ask you about the patch to opcodes/cgen-ibld.in 
> below. It was suggested that you had added the #if 0 a short while
> ago.

I do not remmeber doing that, but I think that it is probably very
likely that I did.  (I was patching lots of things at the time, trying
to remove all the compile time warnings).

> Did you intend to remove the call to cgen_get_insn_value?

No, that was definitely a SNAFU.

> Putting it back solves problems for a number of different ports.

Agreed.  Do you want me to do this or will you ?

> - #if 0
> -   int big_p = CGEN_CPU_INSN_ENDIAN (cd) == CGEN_ENDIAN_BIG;
> - 
>     x = cgen_get_insn_value (cd, bufp, word_length);
> - #endif

Note - the definition and use of big_p is still redundant.

Cheers
        Nick