This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gas: bad output of double pseudo instruction
- From: Nick Clifton <nickc at redhat dot com>
- To: Bosco García <jbgg dot gnu at gmail dot com>, binutils at sourceware dot org
- Date: Thu, 22 Aug 2019 12:59:58 +0100
- Subject: Re: [PATCH] gas: bad output of double pseudo instruction
- References: <CAKjy0qhn3paktSRurNVgE-qWxjF+ny24NttA6bNy3N8kGp81xQ@mail.gmail.com> <CAKjy0qj3FPa5=s9k3g-kc0bBDY84V7mtAarPdZoC1kYg0Y5SLQ@mail.gmail.com>
Hi Bosco,
> Is there any problem with this patch?
Yes and no. The basic patch itself was fine, but there were a few
minor problems. Specifically the code that adds substract_decimal_point
to decimal_exponent needed to be conditional upon OLD_FLOAT_READS
not being defined. The other issue, was that for a fix like this,
it is always best to include a new test in the assembler testsuite,
just to make sure that the problem stays fixed.
> Is this the right place to submit it?
Not really. The correct place to report bugs like this is the
binutils bugzilla system:
https://sourceware.org/bugzilla/enter_bug.cgi?product=binutils
In this case however I have gone ahead and applied the patch,
added a testcase, and fixed up a few minor formatting issues.
Cheers
Nick
gas/ChangeLog
2019-08-22 Bosco García <jbgg.gnu@gmail.com>
Nick Clifton <nickc@redhat.com>
* atof-generic.c (atof_generic): Do not ignore leading zeros if
they appear after a decimal point.
* testsuite/gas/all/float.s: Extend test to include a number with
a leading decimal point followed by several zeroes.
* testsuite/gas/i386/fp.s: Likewise.
* testsuite/gas/i386/fp.d: Update expected output.