This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix N^2 behavior in _bfd_dwarf2_find_symbol_bias

From: Tom Tromey <tromey at adacore dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: Tom Tromey <tromey at adacore dot com>, binutils at sourceware dot org
Date: Mon, 19 Aug 2019 08:48:46 -0600
Subject: Re: [PATCH] Fix N^2 behavior in _bfd_dwarf2_find_symbol_bias
References: <20190816131941.30430-1-tromey@adacore.com> <20190819021704.GA16691@bubble.grove.modra.org>

>>>>> "Alan" == Alan Modra <amodra@gmail.com> writes:

Alan> On Fri, Aug 16, 2019 at 07:19:41AM -0600, Tom Tromey wrote:
>> * dwarf2.c (_bfd_dwarf2_find_symbol_bias): Create hash table
>> holding symbols.

Alan> OK, but..

>> +  sym_hash = htab_create_alloc (10, hash_asymbol, eq_asymbol,
>> +				NULL, xcalloc, free);
>> +  /* FIXME: Do we need to scan the aranges looking for the lowest
>> +     pc value ?  */

Alan> the above comment doesn't make sense here.  It should stay where it
Alan> was in the func loop since it is referring to function aranges.

Thanks for the review.  I've moved the comment back and I'm going to
check this in now.

Tom

References:
- [PATCH] Fix N^2 behavior in _bfd_dwarf2_find_symbol_bias
  - From: Tom Tromey
- Re: [PATCH] Fix N^2 behavior in _bfd_dwarf2_find_symbol_bias
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]