This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][binutils][AArch64][3/3] Add support for float16 (IEEE format) for AArch64 backend.
- From: Barnaby Wilks <Barnaby dot Wilks at arm dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Mon, 19 Aug 2019 11:23:37 +0000
- Subject: Re: [PATCH][binutils][AArch64][3/3] Add support for float16 (IEEE format) for AArch64 backend.
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EdZrWK8bwJl10PdRBTFzrE7gShBRb1v1wc8f52Ywa/U=; b=niowLfEv6Wd6os2B5gFOQHrZLqj2MaFp7nLBtBqS7ky41X8ro7Ym4Iv7HjiSTJWaszdXhFtkk97Xppmwjjx94/eNQO+2S5zklapgwn792iNQWG+eFoavoO5Z4mFZKm9whq5cDgin2ojrLN/9aJqDlCQ33c7H1LWjUzKM1tbpT9YifI7pyQJq2FCZeOPxeej4CsH8Jt3Yz25J9fUAT4M8BL0oXOYpjRf+lw9PDFjPH9To5TsrGPaU9/3wN+q80UHkc5jJMKzg2wMFWWjbJxkpdG0SJ9hsyWXUpe/V256oHiEU8CYnzDNv2Y8XmZOdH0Pdt+9oDSMqb9ah73UFQtuoZw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sp9cAFHUvihmTsjm7GHDds+0bsIMTDVupt5T2SURbIJk+jDRbrSGkAc0awmbHbpjZicXO110RuJS6STRkKgMJZGoSWFsd8GuZVnF7RcG4JzgU+jteHy49qfWnk9Dy3iE7AbQDnAVs7Oz9uOpsz1Jks7UgJbnaS2jTDJnh4R5kwO5YgWBzg4gkfJG7V+pqCNgjhb4ne2ir8VFirlqf5dcpQ8E/9/REQ7Rdr2mzQTY/ChSswWh66p4ksP8ZU3Lo4p/zegPO29c38Im6cn0m6vXfISRmZVkksTqVyWzD5b6VEnhrx0duV71wRweA0cXS+lOppFEcAh65A++hDeJN/OZcA==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Barnaby dot Wilks at arm dot com;
- References: <bf60fccd-0268-43e9-5cea-343649acb733@arm.com> <ae75487d-8008-b1f6-3d00-952cf9b256e0@arm.com> <145e831d-da54-ec58-ae6a-4b74337b65cf@arm.com>
Hi,
Pinging this patch, could someone give this the once over and apply it
if it's all OK?
This patch doesn't require the generic IEEE float16 patch
(https://sourceware.org/ml/binutils/2019-07/msg00115.html)
to be applied first, as that has already been committed as part of the
Arm patch (https://sourceware.org/ml/binutils/2019-08/msg00080.html).
Regards,
Barney
On 8/8/19 5:27 PM, Barnaby Wilks wrote:
> Hello,
>
> This is an updated patch to include documentation and a NEWS entry for this patch series. (The original patch
> is here https://sourceware.org/ml/binutils/2019-07/msg00117.html).
>
> This is part of a patch series that implements a directive for assembling 16-bit floating point constants for Arm and AArch64.
> This patch includes a NEWS entry that covers the changes made in this AArch64 patch and the previous Arm patch.
>
> This patch implements a float16 directive for assembling 16 bit IEEE 754 floating point numbers
> for AArch64.
>
> The syntax of the directive is:
> .float16 <0-n decimal numbers>
> e.g.
> .float16 0.5
> .float16 10.2, NaN, 452.09
>
> The floats will always be encoded using the binary16 format as described in the
> IEEE 754-2008 standard. There is no need to support Arm's alternative half-precision
> format since AArch64 only supports the IEEE format.
>
> Added testcases to verify the correct encoding (for big and little endian targets) and cross-referenced the encodings with
> GCC's __fp16 type to ensure consistency.
>
> Cross compiled and regtested on aarch64-none-elf and aarch64-none-linux-gnu with no issues.
>
> I don't have write access, so if it's OK then could someone commit on my behalf?
>
> Thanks,
> Barney
>
> gas/ChangeLog:
>
> 2019-08-01 Barnaby Wilks <barnaby.wilks@arm.com>
>
> * config/tc-aarch64.c: Add float16 directive and add "Hh" to acceptable float
> characters.
> * doc/c-aarch64.texi: Documentation for float16 directive.
> * testsuite/gas/aarch64/float16-be.d: New test.
> * testsuite/gas/aarch64/float16-le.d: New test.
> * testsuite/gas/aarch64/float16.s: New test.
> * NEWS: Add NEWS entry.
>