This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix N^2 behavior in _bfd_dwarf2_find_symbol_bias
- From: Alan Modra <amodra at gmail dot com>
- To: Tom Tromey <tromey at adacore dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 19 Aug 2019 11:47:04 +0930
- Subject: Re: [PATCH] Fix N^2 behavior in _bfd_dwarf2_find_symbol_bias
- References: <20190816131941.30430-1-tromey@adacore.com>
On Fri, Aug 16, 2019 at 07:19:41AM -0600, Tom Tromey wrote:
> * dwarf2.c (_bfd_dwarf2_find_symbol_bias): Create hash table
> holding symbols.
OK, but..
> + sym_hash = htab_create_alloc (10, hash_asymbol, eq_asymbol,
> + NULL, xcalloc, free);
> + /* FIXME: Do we need to scan the aranges looking for the lowest
> + pc value ? */
the above comment doesn't make sense here. It should stay where it
was in the func loop since it is referring to function aranges.
--
Alan Modra
Australia Development Lab, IBM