This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Clean up value-prof.c a bit.
- From: Jeff Law <law at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>, binutils at sourceware dot org
- Date: Fri, 16 Aug 2019 09:50:07 -0600
- Subject: Re: [PATCH] Clean up value-prof.c a bit.
- References: <856fa70c-645d-433a-29a4-ca59bd8e435f@suse.cz>
On 8/16/19 5:17 AM, Martin Liška wrote:
> Hi.
>
> The patch is a small clean up.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 2019-08-16 Martin Liska <mliska@suse.cz>
>
> * profile.c (instrument_values): Do not set
> 0 as last argument.
> * tree-profile.c (gimple_gen_interval_profiler): Remove
> last argument.
> (gimple_gen_pow2_profiler): Likewise.
> (gimple_gen_topn_values_profiler): Likewise.
> (gimple_gen_ic_profiler): Likewise.
> (gimple_gen_time_profiler): Likewise.
> (gimple_gen_average_profiler): Likewise.
> (gimple_gen_ior_profiler): Likewise.
> * value-prof.c (dump_histogram_value): Use default
> in switch statement instead of HIST_TYPE_MAX.
> (stream_in_histogram_value): Likewise.
> (gimple_duplicate_stmt_histograms): Do not
> use NULL for implicitly set arguments.
> (gimple_divmod_values_to_profile): Do not use
> reserve+quick_push.
> (gimple_indirect_call_to_profile): Likewise.
> (gimple_find_values_to_profile): Use implicit
> function call arguments.
> * value-prof.h (gimple_alloc_histogram_value):
> Set default values.
> (gimple_gen_interval_profiler): Remove last argument.
> (gimple_gen_pow2_profiler): Likewise.
> (gimple_gen_topn_values_profiler): Likewise.
> (gimple_gen_ic_profiler): Likewise.
> (gimple_gen_time_profiler): Likewise.
> (gimple_gen_average_profiler): Likewise.
> (gimple_gen_ior_profiler): Likewise.
> ---
> gcc/profile.c | 14 +++++++-------
> gcc/tree-profile.c | 36 +++++++++++++++++-------------------
> gcc/value-prof.c | 36 ++++++++++++++++--------------------
> gcc/value-prof.h | 18 +++++++++---------
> 4 files changed, 49 insertions(+), 55 deletions(-)
>
>
OK
jeff