This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][binutils][Arm] Removed unsigned variants of VQ(R)DMLAH and VQ(R)DMLASH instructions.

From: Barnaby Wilks <Barnaby dot Wilks at arm dot com>
To: "binutils at sourceware dot org" <binutils at sourceware dot org>
Cc: "nickc at redhat dot com" <nickc at redhat dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, nd <nd at arm dot com>
Date: Mon, 29 Jul 2019 16:34:43 +0000
Subject: [PATCH][binutils][Arm] Removed unsigned variants of VQ(R)DMLAH and VQ(R)DMLASH instructions.
Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none
Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dWUPom83ba96B3djii8Y9eVDcLJLord1z/F62k5glC0=; b=DNwxobbX0KKpZgxCCRR/Y/CrHCVnBIr0F5rfBgh/tCAFanbvkPvehxeNNgH+avf+7iR3NhyFmmEsEwN4OpB57+au9XKB2S5JxXd9Xn824ZeZoIAqbZKRRRE6PWWvNHy/kR3sQ2U1yP0fdeKWxaycqrVaghXHSSE3aKuzuLFQBT7VcuQZuSnCOhPfCuZM5crHZvZ+nKPNxfaH6naeZFDmidIEjIMd/WX8Ij4XI4/LwIlNSFBJqLpl1GB9KLi7XJev8RNlxBkaB9e1yUkbWm5C0J1TmmEfFWZ6jkz0bD9JDdEmib0/r6n2zXgu2Wku8cgqUxs13zCM3lMkYbovXjHdiA==
Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEDeYJJ8a2iJv+U0EuPQPxMJP8hrxousei1twa6UoCihl5uNtzkHsrimx+QLv9wj34zdRHNYvLYl9e/R667eibaoAUAx7pwZIPxnfSHVes9nNgFC8y3rnvqySogtY9fxEeFG56Ry64/MU5MgOhv0Ir9oA4LdC5xX05otrGmoU1qoqp6FPLTJ2v0/+GkE2k0UPjG06Fm27OvDGnuclZq28ZZbDgjgxXIzQar9hpwrrUh6yeU206/vaNryJLhyZiUvaPzhXj6ZkxmJl/FN1gjGfiC6IYw6OHUcV8QFO13k06VwXjt/egM4YFphks1RUzM2E40dyur6GHidSUJF+6jlYQ==
Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Barnaby dot Wilks at arm dot com;

Hello,

This patch removes the unsigned variants of the VQ(R)DMLAH and VQ(R)DMLASH MVE instructions.

Previously GAS would accept .u32, .u16 and .u8 suffixes to the VQ(R)DMLAH and VQ(R)DMLASH
instructions, however the Armv8.1-M Mainline specification states that these functions only
have signed variations (.s32, .s16 and .s8 suffixes).
This is documented here:
https://static.docs.arm.com/ddi0553/bh/DDI0553B_h_armv8m_arm.pdf?_ga=2.143079093.1892401233.1563295591-999473562.1560847439#page=1183

This is due to an update in the specification, for which we believe no hardware exists yet, so we do not need to support both unsigned
and signed variants, and can just support the (correct) signed variants.

Fixed this by marking the instructions as only having signed variations in GAS
and by masking out the unsigned variations in opcodes.

Added testcases to verify that the error is thrown when the .u32/.u16/.u8 suffix is given to the instructions as
well as updating the positive tests to remove the unsigned variations.

Cross compiled and regtested on arm-none-eabi and arm-none-linux-gnueabihf.

I don't have write access, so if it's OK then could someone commit on my behalf?

Regards,
Barney

gas/ChangeLog:

2019-07-29 Barnaby Wilks <barnaby.wilks@arm.com>

* config/tc-arm.c (do_mve_vqdmlah): Use N_S_32 macro.
(do_neon_qrdmlah): Use N_S_32 macro.
* testsuite/gas/arm/mve-vqdmlah-bad.d: New test.
* testsuite/gas/arm/mve-vqdmlah-bad.l: New test.
* testsuite/gas/arm/mve-vqdmlah-bad.s: New test.
* testsuite/gas/arm/mve-vqdmlah.d: Remove unsigned instruction tests.
* testsuite/gas/arm/mve-vqdmlah.s: Remove unsigned instruction tests.
* testsuite/gas/arm/mve-vqdmlash-bad.d: New test.
* testsuite/gas/arm/mve-vqdmlash-bad.l: New test.
* testsuite/gas/arm/mve-vqdmlash-bad.s: New test.
* testsuite/gas/arm/mve-vqdmlash.d: Remove unsigned instruction tests.
* testsuite/gas/arm/mve-vqdmlash.s: Remove unsigned instruction tests.

opcodes/ChangeLog:

2019-07-29 Barnaby Wilks <barnaby.wilks@arm.com>

* arm-dis.c: Only accept signed variants of VQ(R)DMLAH and VQ(R)DMLASH
instructions.

Attachment: arm-remove-unsigned-instructions.txt
Description: arm-remove-unsigned-instructions.txt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]