This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] gas/ELF: don't accumulate .type settings


On 09.07.2019 07:05, Alan Modra wrote:
> On Mon, Jul 08, 2019 at 06:53:01AM +0000, Jan Beulich wrote:
>> Well, I can see about looking into these, but not before some time
>> next week. Until then all I can suggest is for someone to revert
>> the commit if the failures need to be taken care of quickly.
> 
> I don't think there is any hurry, but this time I'll fix the fails,
> particularly since they involve some MIPS tidies.

Thanks a lot, Alan! I wouldn't have know what to do about those
MIPS issues anyway, i.e. if I had to be dealing with this, I guess
I wouldn't have come farther than ...

> --- a/gas/testsuite/gas/elf/type-2.e
> +++ b/gas/testsuite/gas/elf/type-2.e
> @@ -1,10 +1,20 @@
>    +.+: 0+0 +0 +NOTYPE +LOCAL +DEFAULT +UND *
> +#...
>    +.+: 0+0 +0 +OBJECT +LOCAL +DEFAULT +. test1
> +#...
>    +.+: 0+1 +0 +FUNC +LOCAL +DEFAULT +. test2
> +#...
>    +.+: 0+2 +0 +NOTYPE +LOCAL +DEFAULT +. test3
> +#...
>    +.+: 0+3 +0 +NOTYPE +LOCAL +DEFAULT +. test4
> +#...
>    +.+: 0+4 +0 +NOTYPE +LOCAL +DEFAULT +. test5
> +#...
>    +.+: 0+5 +0 +NOTYPE +LOCAL +DEFAULT +. test6
> +#...
>    +.+: 0+6 +0 +OBJECT +LOCAL +DEFAULT +. test7
> +#...
>    +.+: 0+7 +0 +TLS +LOCAL +DEFAULT +. test8
> +#...
>    +.+: 0+8 +0 +IFUNC +LOCAL +DEFAULT +. test9
> +#pass

... just this part.

And yes, I'm aware that I should have done even wider testing.
I sort of hoped that by having had to fiddle with (and hence
test) hppa (alongside x86) I'd be good enough. I'll know better
next time, apologies.

Jan

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]