Re: [PATCH 2/2] Prune BFD warnings for unknown GNU properties

[Nick Clifton <nickc at redhat dot com>]

Hi H.J.

> and ignore such GNU properties.  This patch adds prune_warnings_property
> to prune such warnings on release branches.

I am wondering if we would want to prune other types of warning message from
the linker.  Not just ones about unknown GNU properties.  I am not sure what
these might be, but it would be helpful to be prepared.  So basically what I
am saying is that I think that the proc ought to be called "prune_warnings"
and then inside it we would have a section for pruning gnu property warnings.
Then if at a later date we decide we want to prune other types of warning,
we already have a framework set up to handle most of the work.



> +# prune_warnings_property -- delete warnings for unknown GNU properties
> +# from TEXT.
> +#
> +# An example is:
> +# ld: warning: /lib64/ld-linux-x86-64.so.2: unsupported GNU_PROPERTY_TYPE (5) type : 0xc0010001

I think that you should extend this comment, to explain why we do not
always prune these warnings.  Something like:

  # Warnings are only pruned from non-experimental code (ie code not
  # on a release branch).  For experimental code we want the warnings
  # as they indicate that the sources need to be updated to recognise
  # the new properties.

Cheers
  Nick