This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64: Display eiz for address with the addr32 prefix


>>> On 14.08.18 at 17:13, <hjl.tools@gmail.com> wrote:
> On Tue, Aug 14, 2018 at 6:38 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 14.08.18 at 15:31, <hjl.tools@gmail.com> wrote:
>>> --- a/gas/testsuite/gas/i386/evex-no-scale-64.d
>>> +++ b/gas/testsuite/gas/i386/evex-no-scale-64.d
>>> @@ -10,5 +10,5 @@ Disassembly of section .text:
>>>   +[a-f0-9]+: 62 f1 7c 48 28 04 05 40 00 00 00        vmovaps 
> 0x40\(,%rax,1\),%zmm0
>>>   +[a-f0-9]+: 62 f1 7c 48 28 04 25 40 00 00 00        vmovaps 0x40,%zmm0
>>>   +[a-f0-9]+: 67 62 f1 7c 48 28 04 05 40 00 00 00     vmovaps 
> 0x40\(,%eax,1\),%zmm0
>>> - +[a-f0-9]+: 67 62 f1 7c 48 28 04 25 40 00 00 00     addr32 vmovaps 
> 0x40,%zmm0
>>> + +[a-f0-9]+: 67 62 f1 7c 48 28 04 25 40 00 00 00     vmovaps 0x40,%zmm0
>>>   +[a-f0-9]+: 62 f1 7c 48 28 04 25 40 00 00 00        vmovaps 0x40,%zmm0
>>
>> But this is a regression: The changed line and the immediately
>> following one become indistinguishable without looking at the
>> opcode bytes to recognize the 0x67 prefix. With no other
> 
> Good point.
> 
>> way of expressing the 32-bit addressing in effect, the addr32
>> should stay.
>>
> 
> Here is the patch to display eiz for address with the addr32 prefix and
> without base nor index registers.

Thanks, LGTM.

Jan



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]