This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86-64: Don't display addr32 without base nor index registers
On Tue, 14 Aug 2018, Jan Beulich wrote:
> >>> On 14.08.18 at 15:31, <hjl.tools@gmail.com> wrote:
> > --- a/gas/testsuite/gas/i386/evex-no-scale-64.d
> > +++ b/gas/testsuite/gas/i386/evex-no-scale-64.d
> > @@ -10,5 +10,5 @@ Disassembly of section .text:
> > +[a-f0-9]+: 62 f1 7c 48 28 04 05 40 00 00 00 vmovaps 0x40\(,%rax,1\),%zmm0
> > +[a-f0-9]+: 62 f1 7c 48 28 04 25 40 00 00 00 vmovaps 0x40,%zmm0
> > +[a-f0-9]+: 67 62 f1 7c 48 28 04 05 40 00 00 00 vmovaps 0x40\(,%eax,1\),%zmm0
> > - +[a-f0-9]+: 67 62 f1 7c 48 28 04 25 40 00 00 00 addr32 vmovaps 0x40,%zmm0
> > + +[a-f0-9]+: 67 62 f1 7c 48 28 04 25 40 00 00 00 vmovaps 0x40,%zmm0
> > +[a-f0-9]+: 62 f1 7c 48 28 04 25 40 00 00 00 vmovaps 0x40,%zmm0
>
> But this is a regression: The changed line and the immediately
> following one become indistinguishable without looking at the
> opcode bytes to recognize the 0x67 prefix. With no other
> way of expressing the 32-bit addressing in effect, the addr32
> should stay.
Agreed.
Ciao,
Michael.