This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 3/6] x86: improve operand reversal
On Fri, Aug 3, 2018 at 8:50 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 03.08.18 at 17:30, <hjl.tools@gmail.com> wrote:
>> On Fri, Aug 3, 2018 at 12:08 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 02.08.18 at 18:43, <hjl.tools@gmail.com> wrote:
>>>> Please don't make any changes to the deprecated ".s".
>>>
>>> Excuse me, but how many more times should I state that I don't
>>> make any changes to its behavior? I solely make {store} no longer
>>> match .s in behavior. In fact I've specifically undone the change
>>> to .s, in anticipation of your objection to any adjustment to it.
>>
>> Why do you change testcases of the .s suffix?
>
> s/change/add to/
>
> Deprecated or no, I think the .s suffix should still work, including
> not causing assembly to fail when used. Try assembling the
> additions without the source adjustments, and I think you'll find
> some will fail. To me such adjustments are not "changes to its
Which one?
> behavior" in the sense that I might break anything that has
> worked before. The perspective to take is that for the existing
> test cases the behavior doesn't change. I'm sorry for not having
> spelled it out this way before. I sincerely hope you don't mean
> me to break again what I've just fixed, just to make sure the
> behavior doesn't change _at all_.
--
H.J.