This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] [PATCH] ld: Add --no-print-map-discarded option


Hi Faraz,

> Yeah, I might have jumped the lights with that patch. I understand that we have
> FSF assignment in place for MIPS Tech. We recently got acquired by Wave. We're
> consulting with lawyers to understand if the assignment stays valid. Otherwise,
> I will re-post once the new copyright assignment comes through. Thanks for the
> feedback.

Great - once that is sorted out, would you mind posting a version 2 of the patch
which addresses these small issues:

  * There should be an entry in ld/NEWS mentioning the new feature.

  * There should be documentation in ld/ld.texi describing the new option.

  * The --help output (from ld_options[] array in lexsup.c) should indicate
    which of the two new options is the default.

  * The linker command line in the new skip-map-discarded.d test driver file
    should include "-e 0" to stop the linker from complaining about the
    starting address not being defined.

  * Either the skip-map-discard.s assembler source file should be modified
    so that the .section directive will work with non-ELF targets (by simply
    omitting all of the text after ".section _foo") or else the placement of
    the "run_dump_test skip-map-discarded" line in gc.exp should be moved so
    that the test is only run for ELF based targets.

  Thanks.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]