This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH, GAS/ARM] Allow assembly of IT blocks with AL condition

From: Prakhar Bahuguna <prakhar dot bahuguna at arm dot com>
To: <binutils at sourceware dot org>
Cc: <nd at arm dot com>, <Richard dot Earnshaw at arm dot com>, <Ramana dot Radhakrishnan at arm dot com>, <Kyrylo dot Tkachov at arm dot com>
Date: Wed, 22 Mar 2017 11:33:16 +0000
Subject: [PATCH, GAS/ARM] Allow assembly of IT blocks with AL condition
Authentication-results: sourceware.org; auth=none
Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com;
Nodisclaimer: True
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

According to the ARMv7-M reference manual, section A7.7.37, the IT instruction
is permitted to accept the AL condition, provided the suffix does not have an
else. However, the assembler does not allow the AL condition to be specified at
all. This patch allows instructions to have the AL condition if they are within
an explicitly defined IT block with the matching condition.

2017-02-28  Prakhar Bahuguna  <prakhar.bahuguna@arm.com>

gas/ChangeLog:

	* gas/config/tc-arm.c (it_fsm_pre_encode): Change conditional to first
	check for MANUAL_IT_BLOCK state, and update explanatory comment.
	* gas/testsuite/gas/arm/arm-it-al.d: New file.
	* gas/testsuite/gas/arm/arm-it-al.s: New file.

Testing done: Ran all gas regression tests, added new test to ensure IT with AL
condition assembles as expected with instructions outside of IT blocks
remaining unaffected.

Okay for master?

--

Prakhar Bahuguna

Attachment: 0001-Allow-assembly-of-IT-blocks-with-AL-condition.patch
Description: Text document

Follow-Ups:
- Re: [PATCH, GAS/ARM] Allow assembly of IT blocks with AL condition
  - From: Richard Earnshaw (lists)

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]