This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][gold] Mips: Correct the definition of _gp and _GLOBAL_OFFSET_TABLE_
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Vladimir Radosavljevic <Vladimir dot Radosavljevic at imgtec dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Wed, 15 Mar 2017 16:53:27 -0700
- Subject: Re: [PATCH][gold] Mips: Correct the definition of _gp and _GLOBAL_OFFSET_TABLE_
- Authentication-results: sourceware.org; auth=none
- References: <3060420525346945A0ADBD567348A917EF93C60C@BADAG02.ba.imgtec.org>
> This patch corrects the definition of _gp and _GLOBAL_OFFSET_TABLE_ symbols.
> With this patch, all _gp scope tests from GNU ld testsuite are passing.
> Depends on https://sourceware.org/ml/binutils/2017-03/msg00146.html.
>
> Regards,
> Vladimir
>
> ChangeLog -
>
> * mips.cc (symbol_refs_local): Return false if a symbol
> is from a dynamic object.
> (Target_mips::got_section): Make _GLOBAL_OFFSET_TABLE_ STV_HIDDEN.
> (Target_mips::set_gp): Refactor. Make _gp STT_NOTYPE and
> STB_LOCAL.
> (Target_mips::do_finalize_sections): Set _gp after all the checks
> for creating .got are done.
> (Target_mips::Scan::global): Remove unused code.
I fixed the merge conflicts and applied this patch on your behalf.
-cary