This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH][gold] PR 21054: Fix GOT when global symbols are forced to local visibility
- From: Vladimir Radosavljevic <Vladimir dot Radosavljevic at imgtec dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "ccoutant at gmail dot com" <ccoutant at gmail dot com>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Wed, 18 Jan 2017 18:23:20 +0000
- Subject: [PATCH][gold] PR 21054: Fix GOT when global symbols are forced to local visibility
- Authentication-results: sourceware.org; auth=none
Don't add global symbol that requires GOT entry to the dynamic symbol table if it is forced to local visibility.
Regards,
Vladimir
ChangeLog -
gold/
PR gold/21054
* mips.cc (Mips_got_info::record_global_got_symbol): Don't add symbol
to the dynamic symbol table if it is forced to local visibility.
(Target_mips::do_finalize_sections): Don't add __RLD_MAP symbol to the
dynamic symbol table if it is forced to local visibility.
diff --git a/gold/mips.cc b/gold/mips.cc
index 4f50574..ca3dd00 100644
--- a/gold/mips.cc
+++ b/gold/mips.cc
@@ -5627,7 +5627,7 @@ Mips_got_info<size, big_endian>::record_global_got_symbol(
mips_sym->set_got_not_only_for_calls();
// A global symbol in the GOT must also be in the dynamic symbol table.
- if (!mips_sym->needs_dynsym_entry())
+ if (!mips_sym->needs_dynsym_entry() && !mips_sym->is_forced_local())
{
switch (mips_sym->visibility())
{
@@ -9781,7 +9781,8 @@ Target_mips<size, big_endian>::do_finalize_sections(Layout* layout,
elfcpp::STV_DEFAULT, 0,
false, false);
- rld_map->set_needs_dynsym_entry();
+ if (!rld_map->is_forced_local())
+ rld_map->set_needs_dynsym_entry();
if (!parameters->options().pie())
// This member holds the absolute address of the debug pointer.