This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Solving symbols from different shared objects?
- From: Han Shen <shenhan at google dot com>
- To: Cary Coutant <ccoutant at gmail dot com>
- Cc: binutils <binutils at sourceware dot org>, Eric Christopher <echristo at google dot com>, Jing Yu <jingyu at google dot com>, Jeff Bailey <jeffbailey at google dot com>, Brooks Moses <bmoses at google dot com>
- Date: Mon, 26 Sep 2016 15:06:25 -0700
- Subject: Re: Solving symbols from different shared objects?
- Authentication-results: sourceware.org; auth=none
- References: <CACkGtrjV8qoNne9YoTx4Kcx=NoT5=GfWmrbCTbKUOiBw1XydQg@mail.gmail.com> <CAJimCsHhb12Fxos4K+UeKGEdpXRVgg4r6ZtbHOpVWbX_eOsHCw@mail.gmail.com>
Thanks, that's great!
Han
On Mon, Sep 26, 2016 at 12:03 PM, Cary Coutant <ccoutant@gmail.com> wrote:
>> diff --git a/gold/symtab.cc b/gold/symtab.cc
>> index b31794a..cdeef7f 100644
>> --- a/gold/symtab.cc
>> +++ b/gold/symtab.cc
>> @@ -881,7 +881,7 @@
>> Symbol_table::define_default_version(Sized_symbol<size>* sym,
>> && sym->is_from_dynobj())
>> ;
>> else if (pdef->second->is_from_dynobj()
>> - && sym->is_from_dynobj()
>> + && sym->is_from_dynobj() && pdef->second->is_defined()
>> && pdef->second->object() != sym->object())
>> ;
>> else
>>
>> Do you think this is a a reasonable fix?
>
> Yes, this is actually the exact fix I was already testing. I'll go
> ahead and commit it.
>
> Thanks!
>
> -cary
--
Han Shen | Software Engineer | shenhan@google.com | +1-650-440-3330