This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][ld] Implement --build-id=uuid on MinGW/MSYS2.

From: Igor Kudrin <ikudrin at accesssoftek dot com>
To: "binutils at sourceware dot org" <binutils at sourceware dot org>
Cc: Nick Clifton <nickc at redhat dot com>, Alan Modra <amodra at gmail dot com>
Date: Mon, 25 Jul 2016 10:15:34 +0000
Subject: [PATCH][ld] Implement --build-id=uuid on MinGW/MSYS2.
Authentication-results: sourceware.org; auth=none

Hi,

This patch adds support for the --build-id=uuid option on Windows
when ld is build in MSYS2 (MinGW) environment. It uses function
UuidCreate() from rpcrt4.dll instead of reading from /dev/urandom,
because the latter is not random enough in that case.

BTW, without the patch, using this option leads to AV.

Best regards,
Igor Kudrin

---
ld/ChangeLog

	* ldbuildid.c [__MINGW32__]: Include windows.h and rpcdce.h.
	(validate_build_id_style) [__MINGW32__]: Allow "uuid" style.
	(generate_build_id) [__MINGW32__]: Fill id_bits using UuidCreate().

Attachment: ld-build-id-uuid.patch.txt
Description: ld-build-id-uuid.patch.txt

Follow-Ups:
- Re: [PATCH][ld] Implement --build-id=uuid on MinGW/MSYS2.
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]