This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PowerPC gold assertion on missing global entry stub
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Tue, 28 Apr 2015 13:45:10 +0930
- Subject: PowerPC gold assertion on missing global entry stub
- Authentication-results: sourceware.org; auth=none
Global entry stubs are used on ELFv2 to provide addresses for
functions not defined in a non-PIC executable but whose address is
taken, in much the same way as PLT stub code is used on other
targets to provide function addresses. We don't want to insert a
global entry stub just because (bogus) debug info refers to the
address of a non-local function, but we also don't want gold to die.
* powerpc.cc (Target_powerpc::Relocate::relocate): Don't assert
on missing global entry stub due to bogus debug info.
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index fddf3fa..3d753b5 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -6836,8 +6836,11 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
&& !is_branch_reloc(r_type))
{
unsigned int off = target->glink_section()->find_global_entry(gsym);
- gold_assert(off != (unsigned int)-1);
- value = target->glink_section()->global_entry_address() + off;
+ if (off != (unsigned int)-1)
+ {
+ value = target->glink_section()->global_entry_address() + off;
+ has_stub_value = true;
+ }
}
else
{
@@ -6859,8 +6862,8 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
rela.get_r_addend());
gold_assert(off != invalid_address);
value = stub_table->stub_address() + off;
+ has_stub_value = true;
}
- has_stub_value = true;
}
if (r_type == elfcpp::R_POWERPC_GOT16
--
Alan Modra
Australia Development Lab, IBM