This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 4/9] binutils,gas,bfd: support an extended set of SPARC hardware capabilities.
- From: David Miller <davem at davemloft dot net>
- To: jose dot marchesi at oracle dot com
- Cc: binutils at sourceware dot org
- Date: Sat, 04 Oct 2014 20:22:06 -0400 (EDT)
- Subject: Re: [PATCH 4/9] binutils,gas,bfd: support an extended set of SPARC hardware capabilities.
- Authentication-results: sourceware.org; auth=none
- References: <1412266782-14873-1-git-send-email-jose dot marchesi at oracle dot com> <1412266782-14873-5-git-send-email-jose dot marchesi at oracle dot com>
From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Date: Thu, 2 Oct 2014 18:19:37 +0200
> -static int hwcap_seen;
> +static unsigned long hwcap_seen;
...
> -static int hwcap_allowed;
> +static unsigned long hwcap_allowed;
...
> + unsigned long hwcaps
> + = (((unsigned long) insn->hwcaps2) << 32) | insn->hwcaps;
"unsigned long" is not necessarily 64-bits.
In fact I do all of my binutils builds with a 32-bit generating
toolset.
If you want to store all of the hw capability bits into a single
variable, you will need to explicitly use a 64-bit type such as
perhap bfd_uint64_t.