This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] read.c: Don't special case the set directive for COFF
- From: Alan Modra <amodra at gmail dot com>
- To: David Majnemer <david dot majnemer at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 4 Jul 2014 14:18:59 +0930
- Subject: Re: [PATCH] read.c: Don't special case the set directive for COFF
- Authentication-results: sourceware.org; auth=none
- References: <CAL7bZ_eQO1D5Rp+7FgLUhm6og6=6pm9JzQtfxExsJM3LnckD7w at mail dot gmail dot com>
On Thu, Jul 03, 2014 at 10:08:03PM -0400, David Majnemer wrote:
> diff --git a/gas/read.c b/gas/read.c
> index 8e1b06e..1e148d8 100644
> --- a/gas/read.c
> +++ b/gas/read.c
> @@ -3187,10 +3187,6 @@ assign_symbol (char *name, int mode)
> symbol_set_frag (symbolP, dummy_frag);
> }
> #endif
> -#ifdef OBJ_COFF
> - /* "set" symbols are local unless otherwise specified. */
> - SF_SET_LOCAL (symbolP);
> -#endif
> }
>
> if (S_IS_DEFINED (symbolP) || symbol_equated_p (symbolP))
The above code can be traced right back to git revision fecd2382,
1991-04-04. Instead of deleting it, you probably should be disabling
it for PE.
--
Alan Modra
Australia Development Lab, IBM