This is the mail archive of the
mailing list for the binutils project.
[PATCH] Fixing issue with "Rearrange MIPS INSN* masks" patch
- From: Andrew Bennett <Andrew dot Bennett at imgtec dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "rdsandiford at googlemail dot com" <rdsandiford at googlemail dot com>
- Date: Tue, 6 May 2014 15:02:12 +0000
- Subject: [PATCH] Fixing issue with "Rearrange MIPS INSN* masks" patch
- Authentication-results: sourceware.org; auth=none
The attached patch and ChangeLog fixes an issue with Mark Shinwell's
"Rearrange MIPS INSN* masks" patch
(https://sourceware.org/ml/binutils/2007-11/msg00231.html). In the patch
the pref instruction had its membership flags changed from I4|I32|G3 to
I4_32|G3. Unfortunately G3 was defined as being I4, which made the actual
expanded flags as: I4|I32|I4 and therefore the membership flags should have
been I4_32. Since the patch was committed G3 was redefined to be I4|EE. My
fix just removes I4 from G3 making the expanded membership flags for pref as
The patch and ChangeLog are below.
Ok to commit?
Software Design Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
2014-05-05 Andrew Bennett <firstname.lastname@example.org>
* mips-opc.c (G3): Remove I4.
diff --git a/opcodes/mips-opc.c b/opcodes/mips-opc.c
index 9181c3f..f3b287f 100644
@@ -296,8 +296,7 @@ decode_mips_operand (const char *p)
#define G2 (T3 \
-#define G3 (I4 \
- |EE \
+#define G3 (EE \
/* 64 bit CPU with 32 bit FPU (single float). */