This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add check_lto_available


On Fri, Oct 11, 2013 at 06:09:43PM +0100, H.J. Lu wrote:
> On Fri, Oct 11, 2013 at 5:36 AM, Richard Earnshaw <rearnsha@arm.com> wrote:
> > HJ,
> >
> > Why does this patch try to produce a shared object as part of
> > determining whether LTO works?  If you have LTO but not shared object
> > support in a toolchain this means we don't test LTO properly.
> >
> 
> LTO tests also check if shared library works correctly with LTO.

lto.exp does hav a condition to guard those:

303 if { [is_elf_format]
304      && [run_host_cmd_yesno $CC "-shared -fPIC $srcdir/$subdir/dummy.c -o tmpdir/t.so"] } {
305     run_cc_link_tests $lto_link_elf_tests
....
313 }

Since the other tests seem valid for toolchains that doesn't support shared
library, Shouldn't check_lto_availble have a check that doesn't use -shared ?

VP



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]