This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: binutils-2.23.90 snapshot is available


On Fri, Sep 20, 2013 at 5:16 PM, Allan McRae <allan@archlinux.org> wrote:
> On 20/09/13 21:53, Allan McRae wrote:
>> On 20/09/13 18:28, Tristan Gingold wrote:
>>> Hi,
>>>
>>> I have just uploaded prerelease 2.23.90 for binutils 2.24 at:
>>> ftp://sourceware.org/pub/binutils/snapshots/binutils-2.23.90.tar.bz2
>>>
>>> b278da68838a5548e671ad835576a8fe  binutils-2.23.90.tar.bz2
>>>
>>> This snapshot was sanity-checked for i686-pc-linux-gnu
>>> Please test it for your favorite hosts/targets.
>>>
>>> Tristan.
>>
>> I see one new failure on Arch Linux x86_64-unknown-linux-gnu:
>> FAIL: objcopy on compressed debug sections
>>
>> This happened since I last built from binutils trunk at the start of August.
>>
>
> I bisected this to:
>
> https://sourceware.org/git/?p=binutils.git;a=commit;h=4ff704e222625f8bd160755902d8548c0a4ae2d8
>
> * dwarf.c (dwarf_vmatoa): Rename to dwarf_vmatoa_1 and add a
>
> Allan

We get cie_id from

SAFE_BYTE_GET_AND_INC (cie_id, start, offset_size, end);

The size of cie_id is offset_size, not fc->ptr_size. I checked
this patch into trunk.  OK for 2.24 branch?

Thanks.

-- 
H.J.
--
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 5f64635..95ada6f 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2013-09-27  H.J. Lu  <hongjiu.lu@intel.com>
+
+    * dwarf.c (display_debug_frames): Pass offset_size to
+    print_dwarf_vma for cie_id.
+
 2013-09-20  Alan Modra  <amodra@gmail.com>

     * configure: Regenerate.
diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index 8a233aa..bd73647 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -5249,7 +5249,7 @@ display_debug_frames (struct dwarf_section *section,

       printf ("\n%08lx ", (unsigned long) (saved_start - section_start));
       print_dwarf_vma (length, fc->ptr_size);
-      print_dwarf_vma (cie_id, fc->ptr_size);
+      print_dwarf_vma (cie_id, offset_size);

       if (do_debug_frames_interp)
         {
@@ -5385,7 +5385,7 @@ display_debug_frames (struct dwarf_section *section,
       printf ("\n%08lx %s %s FDE cie=%08lx pc=",
           (unsigned long)(saved_start - section_start),
           dwarf_vmatoa_1 (NULL, length, fc->ptr_size),
-          dwarf_vmatoa_1 (NULL, cie_id, fc->ptr_size),
+          dwarf_vmatoa_1 (NULL, cie_id, offset_size),
           (unsigned long)(cie->chunk_start - section_start));

       if (fc->segment_size)
diff --git a/binutils/testsuite/ChangeLog b/binutils/testsuite/ChangeLog
index ac2de1f..6c98a13 100644
--- a/binutils/testsuite/ChangeLog
+++ b/binutils/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2013-09-27  H.J. Lu  <hongjiu.lu@intel.com>
+
+    * binutils-all/x86-64/compressed-1a.d: Updated for 64-bit addresses.
+
 2013-09-12  Nick Clifton  <nickc@redhat.com>

     * binutils-all/x86-64/compressed-1a.d: Update expected output to
diff --git a/binutils/testsuite/binutils-all/x86-64/compressed-1a.d
b/binutils/testsuite/binutils-all/x86-64/compressed-1a.d
index 0dfbdc1..f1e4bbc 100644
--- a/binutils/testsuite/binutils-all/x86-64/compressed-1a.d
+++ b/binutils/testsuite/binutils-all/x86-64/compressed-1a.d
@@ -135,7 +135,7 @@ Contents of the .[z]?debug_str section:

 Contents of the .[z]?debug_frame section:

-00000000 00000014 ffffffff CIE
+00000000 0+014 ffffffff CIE
   Version:               1
   Augmentation:          ""
   Code alignment factor: 1
@@ -151,7 +151,7 @@ Contents of the .[z]?debug_frame section:
   DW_CFA_nop
   DW_CFA_nop

-00000018 00000014 00000000 FDE cie=00000000 pc=0+0000..0+0002
+00000018 0+014 00000000 FDE cie=00000000 pc=0+0000..0+0002

-00000030 00000014 00000000 FDE cie=00000000 pc=0+0010..0+0015
+00000030 0+014 00000000 FDE cie=00000000 pc=0+0010..0+0015


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]