This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Add a LEXLIB variable in binutils/Makefile


On Sep 11, 2013, at 4:31 AM, Tom Tromey <tromey@redhat.com> wrote:

>>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
> 
> Tristan> strangely enough, there are many occurrences to @LEXLIB@ in
> Tristan> binutils/Makefile.am.
> 
> Let me say that it is definitively the preferred style to use $(LEXLIB)
> and not @LEXLIB@.

I think nobody disagree here :-)

> Tristan> This patch simply replaces them by $(LEXLIB) (It also defines
> Tristan> LEXLIB for homogeneity although it appears to be not required).
> 
> It is really not needed.  Automake automatically defines all the
> AC_SUBSTed variables.

Yes, that's correct.  However I followed the current style: define
variables read.  Minor point, I suppose.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]