This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Commit: Fix display of 64-bit CFI and FDE frames
- From: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- To: Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Cc: "nickc at redhat dot com" <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Tue, 17 Sep 2013 10:46:17 +0100
- Subject: Re: Commit: Fix display of 64-bit CFI and FDE frames
- Authentication-results: sourceware.org; auth=none
- References: <87fvta2yjh dot fsf at BigChill dot fritz dot box> <5236D6F5 dot 8030505 at arm dot com> <5236D90E dot 3020105 at arm dot com>
I'd prefer the regexps to be more consistently written. Sometimes we
have <c>*<c><c>123 and sometimes <c>+<c>123
R.
Ok, I've reworked the patch slightly to use the <c>+<c>123 format
consistently.
Nick already approved the previous version and I think this is an
obvious change
from that one, but just in case I'll wait 24 hours before applying it in
case
anyone has some other comments.
Thanks for the review,
Kyrill
diff --git a/ld/testsuite/ld-aarch64/eh-frame.d b/ld/testsuite/ld-aarch64/eh-frame.d
index 88e9988..f3daeb2 100644
--- a/ld/testsuite/ld-aarch64/eh-frame.d
+++ b/ld/testsuite/ld-aarch64/eh-frame.d
@@ -2,7 +2,7 @@
Contents of the .eh_frame section:
-00000000 00000044 00000000 CIE
+0+0000 0+0044 0+0000 CIE
Version: 1
Augmentation: "zR"
Code alignment factor: 2
@@ -34,7 +34,7 @@ Contents of the .eh_frame section:
DW_CFA_nop
DW_CFA_nop
-00000048 00000014 0000004c FDE cie=00000000 pc=f*ffffff80..f*ffffffc0
+0+0048 0+0014 0+004c FDE cie=0+0000 pc=f+fffff80..f+fffffc0
DW_CFA_nop
DW_CFA_nop
DW_CFA_nop
@@ -43,7 +43,7 @@ Contents of the .eh_frame section:
DW_CFA_nop
DW_CFA_nop
-00000060 00000044 00000000 CIE
+0+0060 0+0044 0+0000 CIE
Version: 1
Augmentation: "zR"
Code alignment factor: 2
@@ -75,7 +75,7 @@ Contents of the .eh_frame section:
DW_CFA_nop
DW_CFA_nop
-000000a8 00000014 0000004c FDE cie=00000060 pc=f*ffffffc0..00000000
+0+00a8 0+0014 0+004c FDE cie=0+0060 pc=f+fffffc0..0+0000
DW_CFA_nop
DW_CFA_nop
DW_CFA_nop