This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[s390] Make CLIH take an unsigned immediate
- From: Richard Sandiford <rsandifo at linux dot vnet dot ibm dot com>
- To: binutils at sourceware dot org
- Cc: Andreas dot Krebbel at de dot ibm dot com
- Date: Tue, 17 Sep 2013 09:37:13 +0100
- Subject: [s390] Make CLIH take an unsigned immediate
- Authentication-results: sourceware.org; auth=none
CLIH was listed as having a signed immediate and so would reject large
unsigned operands. This patch gives it an unsigned operand instead,
as for CLFI.
Tested on s390x-linux-gnu. OK to install?
Thanks,
Richard
opcodes/
* s390-opc.txt (clih): Make the immediate unsigned.
gas/testsuite/
* gas/s390/zarch-z196.s, gas/s390/zarch-z196.d: Test CLIH with
4000000000.
Index: opcodes/s390-opc.txt
===================================================================
--- opcodes/s390-opc.txt 2013-07-12 17:48:15.000000000 +0100
+++ opcodes/s390-opc.txt 2013-09-17 09:25:43.035497950 +0100
@@ -995,7 +995,7 @@ cc0d cih RIL_RI "compare immediate high"
b9cf clhhr RRE_RR "compare logical high high" z196 zarch
b9df clhlr RRE_RR "compare logical high low" z196 zarch
e300000000cf clhf RXY_RRRD "compare logical high" z196 zarch
-cc0f clih RIL_RI "compare logical immediate" z196 zarch
+cc0f clih RIL_RU "compare logical immediate" z196 zarch
e300000000c0 lbh RXY_RRRD "load byte high" z196 zarch
e300000000c4 lhh RXY_RRRD "load halfword high" z196 zarch
e300000000ca lfh RXY_RRRD "load high" z196 zarch
Index: gas/testsuite/gas/s390/zarch-z196.s
===================================================================
--- gas/testsuite/gas/s390/zarch-z196.s 2013-05-09 10:24:22.000000000 +0100
+++ gas/testsuite/gas/s390/zarch-z196.s 2013-09-17 09:24:25.010852703 +0100
@@ -16,6 +16,7 @@ foo:
clhlr %r6,%r7
clhf %r6,5555(%r7,%r8)
clih %r6,650000
+ clih %r9,4000000000
lbh %r6,-5555(%r7,%r8)
lhh %r6,-5555(%r7,%r8)
lfh %r6,-5555(%r7,%r8)
Index: gas/testsuite/gas/s390/zarch-z196.d
===================================================================
--- gas/testsuite/gas/s390/zarch-z196.d 2013-05-09 10:24:22.000000000 +0100
+++ gas/testsuite/gas/s390/zarch-z196.d 2013-09-17 09:28:08.914843734 +0100
@@ -22,6 +22,7 @@ Disassembly of section .text:
.*: b9 df 00 67 [ ]*clhlr %r6,%r7
.*: e3 67 85 b3 01 cf [ ]*clhf %r6,5555\(%r7,%r8\)
.*: cc 6f 00 09 eb 10 [ ]*clih %r6,650000
+.*: cc 9f ee 6b 28 00 [ ]*clih %r9,4000000000
.*: e3 67 8a 4d fe c0 [ ]*lbh %r6,-5555\(%r7,%r8\)
.*: e3 67 8a 4d fe c4 [ ]*lhh %r6,-5555\(%r7,%r8\)
.*: e3 67 8a 4d fe ca [ ]*lfh %r6,-5555\(%r7,%r8\)
@@ -257,3 +258,4 @@ Disassembly of section .text:
.*: b9 2b 00 56 [ ]*kmo %r5,%r6
.*: b9 2c 00 00 [ ]*pcc
.*: b9 2d 90 56 [ ]*kmctr %r5,%r6,%r9
+.*: 07 07 [ ]*nopr %r7