This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] Fix: binutils testsuite builds status wrapper unconditionally
- From: Anton Kolesov <Anton dot Kolesov at synopsys dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, "Jeremy Bennett (Jeremy dot bennett at embecosm dot com)" <Jeremy dot bennett at embecosm dot com>, "Simon Cook (simon dot cook at embecosm dot com)" <simon dot cook at embecosm dot com>
- Date: Mon, 16 Sep 2013 11:18:30 +0000
- Subject: RE: [PATCH] Fix: binutils testsuite builds status wrapper unconditionally
- Authentication-results: sourceware.org; auth=none
- References: <39A54937CC95F24AA2F794E2D2B66B1355C1BADC at de02wembxa dot internal dot synopsys dot com> <20130914025655 dot GB473 at bubble dot grove dot modra dot org>
Hi Alan,
Are you sure it is redundant? That would change current default behavior of using testglue. Without this test condition becomes false, if no value is set explicitly.
--
Anton Kolesov
> -----Original Message-----
> From: binutils-owner@sourceware.org [mailto:binutils-owner@sourceware.org]
> On Behalf Of Alan Modra
> Sent: 14 September 2013 06:57
> To: Anton Kolesov
> Cc: binutils@sourceware.org; Jeremy Bennett (Jeremy.bennett@embecosm.com);
> Simon Cook (simon.cook@embecosm.com)
> Subject: Re: [PATCH] Fix: binutils testsuite builds status wrapper
> unconditionally
>
> On Fri, Sep 13, 2013 at 12:19:26PM +0000, Anton Kolesov wrote:
> > --- binutils-ref/binutils/testsuite/binutils-all/objcopy.exp 2012-03-
> 13 04:41:22.000000000 +0400
> > +++ binutils-2.23.52/binutils/testsuite/binutils-all/objcopy.exp
> 2013-09-13 15:41:07.650678480 +0400
> > @@ -561,7 +561,14 @@
> > global test_prog
> > global host_triplet
> >
> > - set res [build_wrapper testglue.o]
> > + if { [target_info exists needs_status_wrapper] == 0 || \
> > + ([target_info needs_status_wrapper] != "" && \
> > + [target_info needs_status_wrapper] != "0") } {
> > + set res [build_wrapper testglue.o]
> > + } else {
> > + set res ""
> > + }
> > +
> > set flags { debug }
> >
> > if { [istarget *-*-uclinux*] && ![istarget tic6x-*-*] } {
>
> This is OK without the redundant "target_info exists" test.
>
> --
> Alan Modra
> Australia Development Lab, IBM