This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix: binutils testsuite builds status wrapper unconditionally


On Fri, Sep 13, 2013 at 12:19:26PM +0000, Anton Kolesov wrote:
> --- binutils-ref/binutils/testsuite/binutils-all/objcopy.exp	2012-03-13 04:41:22.000000000 +0400
> +++ binutils-2.23.52/binutils/testsuite/binutils-all/objcopy.exp	2013-09-13 15:41:07.650678480 +0400
> @@ -561,7 +561,14 @@
>      global test_prog
>      global host_triplet
>      
> -    set res [build_wrapper testglue.o]
> +    if { [target_info exists needs_status_wrapper] == 0 || \
> +         ([target_info needs_status_wrapper] != "" && \
> +          [target_info needs_status_wrapper] != "0") } {
> +        set res [build_wrapper testglue.o]
> +    } else {
> +        set res ""
> +    }
> +	
>      set flags { debug }
>      
>      if { [istarget *-*-uclinux*] && ![istarget tic6x-*-*] } {

This is OK without the redundant "target_info exists" test.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]