This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH, MIPS] Check the source register for bltzal and others
- From: Chao-Ying Fu <Chao-Ying dot Fu at imgtec dot com>
- To: 'Richard Sandiford' <rdsandiford at googlemail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 12 Sep 2013 22:01:36 +0000
- Subject: RE: [PATCH, MIPS] Check the source register for bltzal and others
- Authentication-results: sourceware.org; auth=none
- References: <81D57523CB07B24881D63DE650C6ED82018F9A55 at BADAG02 dot ba dot imgtec dot org> <87txhqkowx dot fsf at talisman dot default>
Richard Sandiford wrote:
> Chao-Ying Fu <Chao-Ying.Fu@imgtec.com> writes:
> > Index: gas/config/tc-mips.c
> > ===================================================================
> > RCS file: /cvs/src/src/gas/config/tc-mips.c,v
> > retrieving revision 1.591
> > diff -u -p -r1.591 tc-mips.c
> > --- gas/config/tc-mips.c 19 Aug 2013 20:07:09 -0000 1.591
> > +++ gas/config/tc-mips.c 11 Sep 2013 23:12:28 -0000
> > @@ -7091,6 +7091,10 @@ match_insn (struct mips_cl_insn *insn, c
> > set_insn_error
> > (0, _("a destination register must be supplied"));
> > }
> > + else if (arg.last_regno == 31
> > + && (strncmp (insn->insn_mo->name, "bltzal", 6) == 0
> > + || strncmp (insn->insn_mo->name,
> "bgezal", 6) == 0))
> > + set_insn_error (0, _("a source register must not be $31"));
>
> "the source register" sounds better than "a source register".
>
> OK with that change, thanks.
Yes. Done. Thanks a lot!
Regards,
Chao-ying