This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch,ARM] Fix emul selection in ld-arm/export-class.exp
- From: Vidya Praveen <vidyapraveen at arm dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, rearnsha at arm dot com, nickc at redhat dot com
- Date: Mon, 2 Sep 2013 11:25:43 +0100
- Subject: Re: [Patch,ARM] Fix emul selection in ld-arm/export-class.exp
- Authentication-results: sourceware.org; auth=none
- References: <20130829134035 dot GB18868 at e103625-lin dot cambridge dot arm dot com>
Ping!
On Thu, Aug 29, 2013 at 02:40:35PM +0100, Vidya Praveen wrote:
> Hello,
>
> ARM Symbol export class test fails for arm-none-linux-gnuebihf because the
> condition introduced by the patch:
>
> https://sourceware.org/ml/binutils/2013-08/msg00100.html
>
> doesn't match arm-none-linux-gnuebihf and ends up choosing armelf_linux
> which is invalid in this case. This patch fixes the condition.
>
> Tested with ld regressions and no new regressions.
>
> OK for trunk?
>
> Regards
> VP
>
> ---
>
> ld/testsuite/ChangeLog
>
> 2013-08-29 Vidya Praveen <vidyapraveen@arm.com>
>
> * ld-arm/export-class.exp: Fix the condition.
>
> diff --git a/ld/testsuite/ld-arm/export-class.exp b/ld/testsuite/ld-arm/export-class.exp
> index 4e33389..8fac9ec 100644
> --- a/ld/testsuite/ld-arm/export-class.exp
> +++ b/ld/testsuite/ld-arm/export-class.exp
> @@ -32,7 +32,7 @@ if { ![istarget arm*-*-linux*] } {
>
> set testname "ARM symbol export class test"
>
> -if [istarget arm*-*-linux*eabi] {
> +if [istarget arm*-*-linux-*eabi*] {
> set emul armelf_linux_eabi
> } else {
> set emul armelf_linux