This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR 15891 infrastructure


On Thu, Aug 29, 2013 at 10:25:08AM +0200, Stephan Schreiber wrote:
> Hi,
> 
> I invested some time in order to get a fix for bug 15891.
> I tried to implement the --as-needed functionality with two passes
> in (in the function elf_link_add_object_symbols() in bfd/elflink.c).
> The first pass just performs some processing in order to figure out
> whether the object is needed or nor. A roll back is performed in any
> way after that.
> The second pass performs the real processing if needed.

I've said before that I probably should have implemented --as-needed
as two passes over the new object symbols, so the fact you're
attempting a two-pass solution is good in my opinion.  However, a
proper two-pass solution should not have any rollback code.  Half
measures don't really make sense.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]