This is the mail archive of the
mailing list for the binutils project.
Re: gas: rx: constify string to rx_error
On Mon, Oct 24, 2011 at 06:09, Alan Modra wrote:
> On Mon, Oct 24, 2011 at 05:22:08AM -0400, Mike Frysinger wrote:
>> On Wed, Oct 19, 2011 at 12:01, Mike Frysinger wrote:
>> > building rx's gas code atm fails:
>> > rx-parse.c: In function ‘rx_parse’:
>> > rx-parse.c:3774:9: error: passing argument 1 of ‘rx_error’ discards ‘const’
>> > qualifier from pointer target type [-Werror]
>> > ../../../gas/config/rx-defs.h:40:12: note: expected ‘char *’ but argument is of
>> > type ‘const char *’
>> > cc1: all warnings being treated as errors
>> > 2011-10-19 ?Mike Frysinger ?<firstname.lastname@example.org>
>> > ? ? ? ?* config/rx-defs.h (rx_error): Add const to first arg.
>> > ? ? ? ?* config/rx-parse.y (rx_error): Likewise.
>> so people OK with this ?
> I gave an OK in http://sourceware.org/ml/binutils/2011-10/msg00181.html
sorry, you did. i got distracted by the question.