This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix double-counting of MIPS dynamic relocs
- From: Daniel Jacobowitz <drow at false dot org>
- To: binutils at sourceware dot org, rdsandiford at googlemail dot com
- Date: Wed, 6 Aug 2008 16:16:50 -0400
- Subject: Re: Fix double-counting of MIPS dynamic relocs
- References: <874p5xsylf.fsf@firetop.home>
On Wed, Aug 06, 2008 at 09:00:28PM +0100, Richard Sandiford wrote:
> I was updating the GOT patches to work with:
>
> http://sources.redhat.com/ml/binutils/2008-07/msg00350.html
>
> and noticed that that patch double-counted relocations against
> versioned symbols. The hash table callback is called for both
> the indirect and direct definitions, and was reserving relocations
> for both.
>
> This is just a (small) pessimisation at the moment, but it
> triggered an assert I added in the GOT patches.
>
> Tested on mips64-linux-gnu (both with GCC and binutils).
> OK to install?
Yes, thanks for fixing this.
--
Daniel Jacobowitz
CodeSourcery