This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
src/gas ChangeLog config/tc-mips.c
- From: vapier at sourceware dot org
- To: binutils-cvs at sourceware dot org
- Date: 22 May 2012 01:55:17 -0000
- Subject: src/gas ChangeLog config/tc-mips.c
CVSROOT: /cvs/src
Module name: src
Changes by: vapier@sourceware.org 2012-05-22 01:55:17
Modified files:
gas : ChangeLog
gas/config : tc-mips.c
Log message:
gas: mips: fix segfault with invalid default cpu strings
If you configure gas for a mips32el-* target, the default cpu calculation
gets mangled, and we end up passing and invalid value as the default cpu.
If you try executing gas after that, it segfaults. This is because it
assumes that the default cpu value is always valid.
$ ./gas/as-new
Assembler messages:
Error: Bad value (2) for default CPU
Segmentation fault (core dumped)
I'm not debating that the target tuple is valid, just that gas shouldn't
crash. So add a friendly assert to avoid that.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/ChangeLog.diff?cvsroot=src&r1=1.4745&r2=1.4746
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-mips.c.diff?cvsroot=src&r1=1.505&r2=1.506