This is the mail archive of the archer@sourceware.org mailing list for the Archer project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [python][rfc] Attempt to print the base class if a there is no Python pretty-printer for a derived class.


>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> It works in so much as this is a "do or continue with the old logic";
Phil> the existing Python pretty-printers would handle these if they were
Phil> called, no?

My understanding of the current code is that if you have a repeated
virtual base class, it will only be printed once.

So, the test case here would be to have a pretty-printer for the
virtual base -- then, make sure that it is only invoked a single time.

Phil> I was thinking of a documentation patch in the narrative
Phil> regarding printer selection too. But is this just going to be
Phil> superfluous to the reader?

My first reaction is that we don't need a documentation update for
this.  It is just a simple extension of the generic logic to a
different case of printing -- this change is a technical one, related
to the implementation, not really a different use.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]